Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing space at end of strings in NUM_WORDS #759

Closed
Derek-Jones opened this issue Jan 20, 2017 · 2 comments
Closed

Missing space at end of strings in NUM_WORDS #759

Derek-Jones opened this issue Jan 20, 2017 · 2 comments
Labels
bug Bugs and behaviour differing from documentation lang / en English language data and models

Comments

@Derek-Jones
Copy link

The following code in spacy/orth.pyx

NUM_WORDS = set('zero one two three four five six seven eight nine ten'
'eleven twelve thirteen fourteen fifteen sixteen seventeen'
'eighteen nineteen twenty thirty forty fifty sixty seventy'
'eighty ninety hundred thousand million billion trillion'
'quadrillion gajillion bazillion'.split())

is missing a space character after ten, seventeen, seventy, trillion.

At the moment ten is not recognised as a number, but teneleven is treated as like_number.

@ines ines added bug Bugs and behaviour differing from documentation lang / en English language data and models labels Jan 20, 2017
@ines
Copy link
Member

ines commented Jan 20, 2017

Thanks – will be pushing the fix and regression test in a second! Also, now that I see it, this data should probably be moved to the English language data at some point in the future.

@ines ines closed this as completed in 09ecc39 Jan 20, 2017
ines added a commit that referenced this issue Jan 20, 2017
@lock
Copy link

lock bot commented May 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and behaviour differing from documentation lang / en English language data and models
Projects
None yet
Development

No branches or pull requests

2 participants