Check for assets with size of 0 bytes #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I've wanted this check! Great idea thanks. |
svlandeg
added
enhancement
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
svlandeg
approved these changes
Jan 11, 2022
polm
pushed a commit
to polm/spaCy
that referenced
this pull request
Jan 17, 2022
* Check for assets with size of 0 bytes * Update spacy/cli/project/assets.py Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into an issue where, if downloading an asset (without a checksum) failed in a way that left a 0-byte file on disk, the next run of
spacy project assetswould assume the asset doesn't need to be redownloaded. 0-byte files are probably never what we want, so if that's the case, let's delete it so it will reattempt the download (and warn the user):Types of change
Bug fix
Checklist