Bugfix for similarity return types #10051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the past, calls to
Lexeme.similarity()
,Span.similarity()
andToken.similarity()
have returned inconsistent return types: depending on whether or not matrix multiplication was performed to determine the similarity and whether or not Numpy (CPU) or Cupy (GPU) was in use, the return value could be a native Python float, a Numpy float or a Cupy array. This pull request duplicates the pre-existing behaviour ofDoc.similarity()
and ensures that all return values are native floats.Types of change
Bug fix
Checklist