Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spaces in Doc.from_docs for empty docs #10052

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Fix spaces in Doc.from_docs for empty docs #10052

merged 1 commit into from
Jan 18, 2022

Conversation

adrianeboyd
Copy link
Contributor

@adrianeboyd adrianeboyd commented Jan 13, 2022 •
edited
Loading

Description

Fix spaces in Doc.from_docs(ensure_whitespace=True) for cases where a doc ending in whitespace is followed by an empty doc.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Fix spaces in Doc.from_docs for empty docs
53d4334 
Fix spaces in `Doc.from_docs(ensure_whitespace=True)` for cases where an
doc ending in whitespace is followed by an empty doc.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects labels Jan 13, 2022
@adrianeboyd adrianeboyd linked an issue Jan 13, 2022 that may be closed by this pull request
ValueError: [E873] Unable to merge a span from doc.spans with key 'sc' #9871
Closed
@svlandeg svlandeg merged commit 4dfd559 into explosion:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError: [E873] Unable to merge a span from doc.spans with key 'sc'
2 participants
@adrianeboyd @svlandeg