Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mixed case model package names #10223

Conversation

adrianeboyd
Copy link
Contributor

Description

Support mixed case model package names

The current status seems to be:

  • pip and setuptools support mixed case names, although case isn't significant in package names
  • you can load a package with uppercase characters with spacy.load() or with a direct import
  • spacy validate and the CI CLI tests fail on cases with uppercase characters

I don't see any evidence of the bug mentioned in 8dbe49e in tests with current versions of setuptools and pip.

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added feat / pipeline Feature: Processing pipeline and components feat / cli Feature: Command-line interface labels Feb 7, 2022
@adrianeboyd adrianeboyd requested a review from ines February 8, 2022 07:44
@adrianeboyd adrianeboyd merged commit a9ee5bf into explosion:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat / cli Feature: Command-line interface feat / pipeline Feature: Processing pipeline and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants