SpanGroup(s)
-related optimizations
#11380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were needlessly performing a serialization-deserialization round-trip just to copy a string
Dict
ofSpanGroup
s. This PR replaces that with a straight-forward copy of thedict
's constituents. To facilitate this, a new keyword argument was added toSpanGroup.copy()
that allows the user to pass a new reference document to which the copy is bound.Improvements in performance can be seen in this PR.
Types of change
Refactor, enhancement
Checklist