Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default configs to recent tok2vec versions #11618

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

svlandeg
Copy link
Member

Description

Some default configurations of our components were still using legacy version for the tok2vec layer.

Types of change

fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added enhancement Feature requests and improvements feat / textcat Feature: Text Classifier feat / spancat Feature: Span Categorizer v3.5 Related to v3.5 labels Oct 11, 2022
@svlandeg
Copy link
Member Author

Requires #11619 to fix the mypy error on the CI

@adrianeboyd
Copy link
Contributor

No longer needs #11619 due to thinc v8.1.4!

@rmitsch
Copy link
Contributor

rmitsch commented Oct 13, 2022

@adrianeboyd This should be good to merge then, no?

@adrianeboyd adrianeboyd merged commit 2ce6aad into explosion:develop Oct 17, 2022
@svlandeg svlandeg deleted the update/tok2vec branch November 14, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / spancat Feature: Span Categorizer feat / textcat Feature: Text Classifier v3.5 Related to v3.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants