Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in errors used in the beam code that were removed at some point #11935

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Add in errors used in the beam code that were removed at some point #11935

merged 1 commit into from
Dec 7, 2022

Conversation

polm
Copy link
Contributor

@polm polm commented Dec 6, 2022

Description

There are a few errors in the beam search code that were removed (it looks like in #5664). I don't think there's any way to use the beam code at the moment, but as long as it's around the errors it refers to should also be present.

Types of change

minor fix?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@polm
Add in errors used in the beam code that were removed at some point
e89e11c 
I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
@polm polm added the feat / parser Feature: Dependency Parser label Dec 6, 2022
@svlandeg
Copy link
Member

svlandeg commented Dec 7, 2022

Good catch!

There are a few errors in the beam search code that were removed (it looks like in #5664).

#5664 was fine, because at the time (if you look at the history) the beam parsing was in fact removed, it was only added back in with #6369, where we didn't catch that the error messages were not pointing to anything anymore...

@svlandeg svlandeg merged commit 5c3a60e into explosion:master Dec 7, 2022
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 9, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
b83abde 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 9, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
1da0a02 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 9, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
1781986 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 9, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
6b8e2db 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 9, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
6a9a17b 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 9, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
cc0c7da 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 12, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
dbb30f7 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 12, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
0de7892 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 12, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
337ebda 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Dec 12, 2022
@polm @adrianeboyd
Add in errors used in the beam code that were removed at some point (e…
eea195c 
…xplosion#11935)

I don't think there's any way to use the beam code at the moment, but as
long as it's around the errors it refers to should also be present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
feat / parser Feature: Dependency Parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polm @svlandeg