Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New console logger with expanded progress tracking #11972

Merged
merged 6 commits into from
Dec 23, 2022

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Dec 14, 2022

Description

This PR adds ConsoleLogger.v3 which expands the progress bar feature to count up the training/distillation steps to either the next evaluation pass or the maximum number of steps.

Additionally, ConsoleLogger.v2 was modified to call v3 while retaining its current behaviour.

Types of change

New feature

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

This addition expands the progress bar feature to count up the training/distillation steps to either the next evaluation pass or the maximum number of steps.
@shadeMe shadeMe added the loggers Loggers and spacy-loggers label Dec 14, 2022
spacy/training/loggers.py Outdated Show resolved Hide resolved
@svlandeg svlandeg added the enhancement Feature requests and improvements label Dec 16, 2022
Copy link
Contributor

@polm polm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for putting it together!

One thing that came up is that the docs didn't explain defaults - it looks like they had been like that before, but we should clarify it.

One thing came to mind looking at the code here was whether the case where max_steps = 0 would work, but it looks like tqdm will handle that reasonably by showing progress without a bar.

website/docs/api/top-level.md Show resolved Hide resolved
website/docs/api/top-level.md Outdated Show resolved Hide resolved
website/docs/api/top-level.md Outdated Show resolved Hide resolved
website/docs/api/top-level.md Outdated Show resolved Hide resolved
spacy/training/loggers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@polm polm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there were a few small punctuation issues, but this should be good now!

spacy/training/loggers.py Outdated Show resolved Hide resolved
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We'll want to move the v2 to legacy though, right?

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks!

@shadeMe shadeMe merged commit aa2b471 into explosion:master Dec 23, 2022
@shadeMe shadeMe deleted the feature/training-progress-bar branch December 23, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements loggers Loggers and spacy-loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants