Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix speed problem with top_k>1 on CPU in edit tree lemmatizer #12017

Merged
merged 10 commits into from
Jan 20, 2023
Merged

Fix speed problem with top_k>1 on CPU in edit tree lemmatizer #12017

merged 10 commits into from
Jan 20, 2023

Commits on Dec 22, 2022

  1. Refactor _scores2guesses

    @richardpaulhudson
    richardpaulhudson committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    278181a View commit details
    Browse the repository at this point in the history

  2. Handle arrays on GPU

    @richardpaulhudson
    richardpaulhudson committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9430306 View commit details
    Browse the repository at this point in the history

  3. Convert argmax result to raw integer 

    Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
    @richardpaulhudson @shadeMe
    richardpaulhudson and shadeMe authored Dec 22, 2022
    Configuration menu
    Copy the full SHA
    95a4835 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Use NumpyOps() to copy data to CPU 

    Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
    @richardpaulhudson @shadeMe
    richardpaulhudson and shadeMe authored Dec 23, 2022
    Configuration menu
    Copy the full SHA
    361b64e View commit details
    Browse the repository at this point in the history

  2. Changes based on review comments

    @richardpaulhudson
    richardpaulhudson committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    4daf5e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Use different _scores2guesses depending on tree_k

    @richardpaulhudson
    richardpaulhudson committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8d487bf View commit details
    Browse the repository at this point in the history

  2. Add tests for corner cases

    @richardpaulhudson
    richardpaulhudson committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    781661b View commit details
    Browse the repository at this point in the history

  3. Add empty line for consistency

    @richardpaulhudson
    richardpaulhudson committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    00b1d9a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Improve naming 

    Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
    @richardpaulhudson @danieldk
    richardpaulhudson and danieldk authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    175b487 View commit details
    Browse the repository at this point in the history

  2. Improve naming 

    Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
    @richardpaulhudson @danieldk
    richardpaulhudson and danieldk authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    dd5975a View commit details
    Browse the repository at this point in the history