Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alignment_mode argument to Span.char_span() #12145

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

itssimon
Copy link
Contributor

@itssimon itssimon commented Jan 23, 2023

Description

Adds the alignment_mode parameter present in Doc.char_span() to Span.char_span() as well.

Types of change

Enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added enhancement Feature requests and improvements feat / doc Feature: Doc, Span and Token objects labels Jan 23, 2023
Copy link
Contributor

@adrianeboyd adrianeboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This also needs to be added to the API docs under website/docs/api/span.mdx. Add a tag in the Name column that this is new in 3.5.1 (<Tag variant="new">3.5.1</Tag>) and note that the docs are formatted using prettier, since you'll probably need to reformat the whole table.

spacy/tokens/span.pyx Outdated Show resolved Hide resolved
spacy/tokens/span.pyx Show resolved Hide resolved
itssimon and others added 3 commits January 23, 2023 22:11
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
@adrianeboyd
Copy link
Contributor

Thanks again for the PR!

@adrianeboyd adrianeboyd merged commit 774c10f into explosion:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants