Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for non-default vectors with PretrainVectors #12366

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Raise error for non-default vectors with PretrainVectors #12366

merged 1 commit into from
Mar 6, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Raise error for non-default vectors with PretrainVectors

  • Switch to absolute imports in pretraining tests.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity feat / ux Feature: User experience, error messages etc. labels Mar 6, 2023
@adrianeboyd adrianeboyd linked an issue Mar 6, 2023 that may be closed by this pull request
Zero loss when pretraining on floret vectors #12363
Closed
@svlandeg svlandeg merged commit 260cb9c into explosion:master Mar 6, 2023
adrianeboyd added a commit to adrianeboyd/spaCy that referenced this pull request Mar 9, 2023
@adrianeboyd
Raise error for non-default vectors with PretrainVectors (explosion#1…
6177c87 
…2366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / ux Feature: User experience, error messages etc. feat / vectors Feature: Word vectors and similarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero loss when pretraining on floret vectors
2 participants
@adrianeboyd @svlandeg