Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Span.sents edge case #12484

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Fix Span.sents edge case #12484

merged 1 commit into from
Mar 29, 2023

Conversation

rmitsch
Copy link
Contributor

@rmitsch rmitsch commented Mar 29, 2023 •
edited
Loading

Description

Types of change

Fix Span.sents edge case of Span instance being the only one in the last sentence of its Doc instance.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects labels Mar 29, 2023
@rmitsch rmitsch self-assigned this Mar 29, 2023
@rmitsch rmitsch marked this pull request as ready for review March 29, 2023 13:26
@svlandeg svlandeg merged commit d85df9d into explosion:master Mar 29, 2023
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Apr 3, 2023
@rmitsch @adrianeboyd
Fix Span.sents for edge case of Span being the only Span in the last …
8d06487 
…sentence of a Doc. (explosion#12484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rmitsch rmitsch

Labels
bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @svlandeg