Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Span.kb_id/Span.id strings to Doc/DocBin serialization if set #12493

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Add Span.kb_id/Span.id strings to Doc/DocBin serialization if set #12493

merged 2 commits into from
Apr 3, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Add Span.kb_id/Span.id strings to Doc/DocBin serialization if strings have been added.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects labels Apr 3, 2023
@adrianeboyd adrianeboyd linked an issue Apr 3, 2023 that may be closed by this pull request
E018 (Can't retrieve string for hash) error when fetching span IDs from SpanRuler #12407
Closed
@svlandeg svlandeg mentioned this pull request Apr 3, 2023
Closed
3 tasks
@svlandeg svlandeg merged commit 4a1ec33 into explosion:master Apr 3, 2023
adrianeboyd added a commit to adrianeboyd/spaCy that referenced this pull request Apr 3, 2023
@adrianeboyd
Add Span.kb_id/Span.id strings to Doc/DocBin serialization if set (ex…
bbf232e 
…plosion#12493)

* Add Span.kb_id/Span.id strings to Doc/DocBin serialization if set

* Format
@adrianeboyd adrianeboyd mentioned this pull request Apr 28, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E018 (Can't retrieve string for hash) error when fetching span IDs from SpanRuler
2 participants
@adrianeboyd @svlandeg