Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend to thinc v8.2 #12897

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

adrianeboyd
Copy link
Contributor

Description

Extend to thinc v8.2.

Types of change

Enhancement?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added the v3.7 Related to v3.7 label Aug 9, 2023
@adrianeboyd adrianeboyd marked this pull request as draft August 9, 2023 09:21
@adrianeboyd
Copy link
Contributor Author

@explosion-bot please test_slow_gpu --thinc-branch develop

@explosion-bot
Copy link
Collaborator

explosion-bot commented Aug 9, 2023

🪁 Successfully triggered build on Buildkite

URL: https://buildkite.com/explosion-ai/spacy-slow-gpu-tests/builds/211

@adrianeboyd
Copy link
Contributor Author

The slow GPU tests look fine. I cancelled the CI tests because they wouldn't be testing thinc v8.2 until there's a release on pypi. The CI checks should be re-run after the release.

@adrianeboyd
Copy link
Contributor Author

@explosion-bot please test_slow_gpu --thinc-branch develop

@explosion-bot
Copy link
Collaborator

explosion-bot commented Aug 11, 2023

🪁 Successfully triggered build on Buildkite

URL: https://buildkite.com/explosion-ai/spacy-slow-gpu-tests/builds/212

@adrianeboyd adrianeboyd marked this pull request as ready for review August 11, 2023 11:05
@adrianeboyd adrianeboyd merged commit 6a4aa43 into explosion:develop Aug 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.7 Related to v3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants