Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore spacy.cli.project API #13053

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Restore spacy.cli.project API #13053

merged 2 commits into from
Oct 10, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Among other things, removing this API breaks the projects tests. This is the very blunt solution that is hopefully equivalent enough to the previous API. You could obviously potentially be more selective with the imports or reexports in weasel.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface projects spaCy projects and project templates labels Oct 10, 2023
@adrianeboyd adrianeboyd merged commit 77c568e into explosion:master Oct 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmitsch rmitsch rmitsch approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface projects spaCy projects and project templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianeboyd @rmitsch