Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setup.py spacy req string for packaging #1674

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

twerkmeister
Copy link
Contributor

Description

spacy requirement string for model packages was broken.
It should be spacy>=2.0.2 instead of spacy2.0.2

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed. (There are no tests for the cli packaging)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Requirement should be `spacy>=2.0.2` instead of `spacy2.0.2`
@explosion-bot
Copy link
Collaborator

Hi @twerkmeister, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agrement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the .github/contributors directory and add it to this pull request. If your pull request targets a branch that's not master, for example develop, make sure to submit the Contributor Agreement to the master branch. Thanks a lot!

If you've already included the Contributor Agreement in your pull request above, you can ignore this message.

@honnibal
Copy link
Member

honnibal commented Dec 4, 2017

Thank!

@honnibal honnibal merged commit f5cae1f into explosion:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants