Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ja leading spaces #5969

Merged
merged 2 commits into from
Aug 25, 2020
Merged

fix ja leading spaces #5969

merged 2 commits into from
Aug 25, 2020

Conversation

hiroshi-matsuda-rit
Copy link
Contributor

Bug fix for spacy.lang.ja: exception raised when dtoken.surface starts with " " #5961

Description

Change the condition of space after by seeing the surface of the next token.

Types of change

a bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg linked an issue Aug 25, 2020 that may be closed by this pull request
cannot analyze ̄ ̄ with japanese models #5961
Closed
@svlandeg svlandeg added bug Bugs and behaviour differing from documentation lang / ja Japanese language data and models labels Aug 25, 2020
svlandeg
svlandeg reviewed Aug 25, 2020
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such a quick fix! I suggest to have the original case from that issue as a unit test? (and preferably some additional cases as well).

@hiroshi-matsuda-rit
Copy link
Contributor Author

@svlandeg I added a text to NAUGHTY_STRINGS. Is it okay?

@svlandeg
Copy link
Member

I think so! @adrianeboyd : does this look OK to you?

@adrianeboyd
Copy link
Contributor

I think it looks fine!

@hiroshi-matsuda-rit
Copy link
Contributor Author

CI tests done.
How about develop branch?
May I send the same PR to develop?

@svlandeg
Copy link
Member

There's no need for that, we sync such fixes periodically!

@svlandeg svlandeg merged commit 332803e into explosion:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation lang / ja Japanese language data and models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot analyze ̄ ̄ with japanese models
3 participants
@hiroshi-matsuda-rit @svlandeg @adrianeboyd