Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include runtime-relevant config in package CLI dependency detection #9211

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

ines
Copy link
Member

@ines ines commented Sep 14, 2021

Description

Previously, the external package dependency detection in spacy package would include the entire config, including sections not relevant at runtime. So if the [training] or [initialize] block included references to registered functions exposed by third-party packages, these packages would become dependencies of the packaged pipeline. That's unideal, so this PR only includes the runtime-relevant sections nlp and components.

Types of change

fix / enhancement (?)

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines added the feat / cli Feature: Command-line interface label Sep 14, 2021
@svlandeg svlandeg merged commit 20f63e7 into master Sep 15, 2021
@svlandeg svlandeg deleted the fix/package-dependencies-runtime-only branch September 15, 2021 21:16
danieldk pushed a commit to danieldk/spaCy that referenced this pull request Sep 21, 2021
adrianeboyd pushed a commit to adrianeboyd/spaCy that referenced this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat / cli Feature: Command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants