Sync vocab in vectors and components sourced in configs #9335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianeboyd
added
bug
adrianeboyd
force-pushed
the
bugfix/strings-in-sourced-components
branch
3 times, most recently
from
48f1413
to
c808c1f
Compare
Since a component may reference anything in the vocab, share the full vocab when loading source components and vectors (which will include `strings` as of explosion#8909). When loading a source component from a config, save and restore the vocab state after loading source pipelines, in particular to preserve the original state without vectors, since `[initialize.vectors] = null` skips rather than resets the vectors. The vocab references are not synced for components loaded with `Language.add_pipe(source=)` because the pipelines are already loaded and not necessarily with the same vocab. A warning could be added in `Language.create_pipe_from_source` that it may be necessary to save and reload before training, but it's a rare enough case that this kind of warning may be too noisy overall.
adrianeboyd
force-pushed
the
bugfix/strings-in-sourced-components
branch
from
b9e77b5
to
9776ffd
Compare
adrianeboyd
changed the title
ines
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since a component may reference anything in the vocab, share the full vocab when loading source components and vectors (which will include
stringsas of #8909).When loading a source component from a config, save and restore the vocab state after loading source pipelines, in particular to preserve the original state without vectors, since
[initialize.vectors] = nullskips rather than resets the vectors.The vocab references are not synced for components loaded with
Language.add_pipe(source=)because the pipelines are already loaded and not necessarily with the same vocab. A warning could be added inLanguage.create_pipe_from_sourcethat it may be necessary to save and reload before training, but it's a rare enough case that this kind of warning may be too noisy overall.Types of change
Bug fix.
Checklist