Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to convert CLI #9465

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Minor fixes to convert CLI #9465

merged 1 commit into from
Oct 14, 2021

Conversation

adrianeboyd
Copy link
Contributor

Description

  • Provide default value for msg
  • Compare paths correctly for file conversion

Types of change

Bug fix?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Minor fixes to convert CLI
623b224 
* Provide default value for `msg`
* Compare paths correctly for file conversion
@adrianeboyd adrianeboyd added the feat / cli Feature: Command-line interface label Oct 14, 2021
@honnibal
Copy link
Member

@negromty Hi, the "Approve changes" feature is intended for repository maintainers. It's not an action you should take on repos you're not maintaining :). (I'm actually really surprised it's possible for you to do it!)

@svlandeg svlandeg merged commit b5143b1 into explosion:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

@negromty negromty negromty approved these changes

Assignees
No one assigned
Labels
feat / cli Feature: Command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianeboyd @honnibal @svlandeg @negromty