Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 architectures for transformer_config #287

Merged
merged 3 commits into from
Aug 17, 2021
Merged

v2 architectures for transformer_config #287

merged 3 commits into from
Aug 17, 2021

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Aug 13, 2021 •
edited
Loading

Follow up on #268:

  • TransformerModel.v2 takes new argument transformer_config
  • updated example configs with new argument
  • docs will be added to spaCy

Also bumping the version to 1.1.0

@svlandeg svlandeg added the enhancement New feature or request label Aug 13, 2021
@svlandeg svlandeg mentioned this pull request Aug 13, 2021
Merged
3 tasks
@adrianeboyd adrianeboyd merged commit 1ba8ffc into explosion:master Aug 17, 2021
@adrianeboyd
Copy link
Contributor

adrianeboyd commented Aug 17, 2021 •
edited
Loading

Edited: sorry, commented on the wrong PR.

@svlandeg svlandeg deleted the fix/versions branch August 17, 2021 06:55
@svlandeg svlandeg added the v1.1 Related to v1.1 label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianeboyd adrianeboyd adrianeboyd left review comments

Assignees
No one assigned
Labels
enhancement New feature or request v1.1 Related to v1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @adrianeboyd