-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct and clarify the handling of empty/zero-length Doc
s during training and inference
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gth documents are correctly ignored
shadeMe
changed the title
Allocate zeroed outputs with the correct width whenever possible
Correct the handling of empty/zero-length docs during training and inference
Jan 26, 2023
shadeMe
changed the title
Correct the handling of empty/zero-length docs during training and inference
Correct the handling of empty/zero-length Jan 26, 2023
Doc
s during training and inference
3 tasks
danieldk
reviewed
Jan 30, 2023
shadeMe
changed the title
Correct the handling of empty/zero-length
Correct and clarify the handling of empty/zero-length Jan 30, 2023
Doc
s during training and inferenceDoc
s during training and inference
danieldk
approved these changes
Jan 30, 2023
Assigned to you Sofie, since you added the handling of zero-length docs, so it would be good get an additional sanity check. |
svlandeg
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice digging, looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues:
Doc
s, but we explicitly clarify why we use zero-width outputs.zip
, i.e., the test always added the empty document to the end of the batch, and the subsequentzip
operation would implicitly skip the last backprop/gradient due to the latter list being shorter than the list of model outputs.It also adds comments about the pre-conditions to clarify the circumstances under which zero-length inputs are passed to the model.
Types of change
Bug Fix
Checklist