Extend support to transformers v4.31 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fall back with warning to `load_state_dict(strict=False)` for backwards compatibility.
adrianeboyd
force-pushed
the
chore/extend-transformers-4.31
branch
from
bb0285c
to
0fee7a5
Compare
|
In most relevant cases there is already a general warning saying it might not work, so I think it could be okay to leave it at that. I think we could put this change in v1.3.0 so it wouldn't affect any existing saved |
|
I think we can add a more informative warning and then still make this change as v1.3.0 so there aren't any surprises with existing packaged models. |
|
I'll just go ahead and do this as v1.3.0 in case people need newer versions of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restrict backwards compatibility test to
transformers<4.31.Types of change
?
Checklist