Config: do not sort positional arguments #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a configuration such as the following: [model] [model.chain] @layers = "chain.v1" [model.chain.*.hashembed] @layers = "HashEmbed.v1" nO = 8 nV = 8 [model.chain.*.expand_window] @layers = "expand_window.v1" window_size = 1 The positional arguments in the chain were sorted, changing the chain order. This change masks the names of positional arguments. Since `sorted` is a stable sort, the order of positional arguments is retained.
danieldk
added
bug
svlandeg
reviewed
Feb 21, 2022
svlandeg
reviewed
Feb 21, 2022
svlandeg
reviewed
Feb 21, 2022
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
svlandeg
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a configuration such as the following:
The positional arguments in the chain were sorted, changing the chain order. This change masks the names of positional arguments. Since
sortedis a stable sort, the order of positional arguments is retained.