Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for Windows #55

Merged
merged 16 commits into from
May 18, 2024
Merged

feature: add support for Windows #55

merged 16 commits into from
May 18, 2024

Conversation

byCedric
Copy link
Member

This change includes a couple of changes, to make Atlas run smoothly on Windows machines.

  1. The module/folder paths in the URLs are now all relative to the bundle's sharedRoot. This helps us not having to care about potential C:\ prefixes.
  2. All AtlasModule and AtlasModuleRef objects now have absolutePath and relativePath (instead of path). The absolutePath is formatted in the system's dialect, so it can be looked up in Metro if necessary. The relativePath is relative to the bundle's sharedRoot and notated in POSIX.
  3. The base64 ID when running Atlas during development is now shorter, and using the relative path of the entry file (using sharedRoot).

@byCedric byCedric merged commit b43545a into main May 18, 2024
2 checks passed
@byCedric byCedric deleted the feature/support-windows branch May 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant