Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[steps] fix resolving custom function path #259

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

szdziedzic
Copy link
Member

Why

The relative function path was resolved always based on a dirname of the main config path, not based on dirname of the imported config file which actually contains the function declaration.

How

Resolve relative function path based on the path to the config file which actually contains the function

Test Plan

Tests

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #259 (d1a4aec) into main (21dfc76) will decrease coverage by 0.17%.
The diff coverage is 84.22%.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   93.24%   93.06%   -0.17%     
==========================================
  Files          21       21              
  Lines         843      850       +7     
  Branches      179      181       +2     
==========================================
+ Hits          786      791       +5     
- Misses         57       59       +2     
Files Changed Coverage Δ
packages/steps/src/cli/cli.ts 0.00% <0.00%> (ø)
packages/steps/src/BuildConfig.ts 93.21% <84.62%> (-1.36%) ⬇️
packages/steps/src/BuildConfigParser.ts 100.00% <100.00%> (ø)
packages/steps/src/BuildStepContext.ts 89.10% <100.00%> (-0.19%) ⬇️

@szdziedzic szdziedzic merged commit adb52f2 into main Aug 2, 2023
@szdziedzic szdziedzic deleted the @szdziedzic/fix-resolving-custom-function-path branch August 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant