[build-tools] Log stdout if build:internal fails
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szdziedzic
approved these changes
Oct 31, 2024
| // is often not enough to debug the issue, so we also log stdout in those cases. | ||
| // It will look awkward (first stderr from pipe, then stdout from here), but | ||
| // it's better than nothing. | ||
| logger.error(`${err.stdout}`); |
There was a problem hiding this comment.
I assume that printing job object with it's secrets is the last operation performed by this command, right? If so if there is any error there shouldn't be any secrets in stdout?
There was a problem hiding this comment.
It's not last per se, but it's close to last. After we print the job we may also start a submission (which theoretically may fail).
Maybe we should revert this after we find the issue with the orchestrator?
There was a problem hiding this comment.
Yeah, we can if it contains any sensitive data and there is a risk of leaking it 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I have trouble understanding why GitHub builds on the new Orchestrator fail consistently.
How
I want to know more about the error than "GraphQL request failed". So, I want to print the second part of the output, the stdout.
Test Plan
I ran a local build with overridden
EXPO_TOKEN=invalid, and printing both stdout and stderr and got: