Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updates] Update fingerprint diff algorithm #461

Merged

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Nov 4, 2024

Why

This PR separates out just the backporting portion of https://app.graphite.dev/github/pr/expo/eas-build/460/updates-Change-fingeprint-diff-to-use-versioned-fingerprint-CLI

Backport the changes from expo/expo#32486 into this local copy of the fingerprint diff mechanism.

This will help debug current fingerprint inconsistencies better before that PR lands (blocked on canary publishes)

How

copypasta

Test Plan

yarn tsc

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

@wschurman wschurman marked this pull request as ready for review November 4, 2024 19:05
Copy link

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍝

Copy link
Member Author

wschurman commented Nov 4, 2024

Merge activity

  • Nov 4, 2:20 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 2:21 PM EST: A user merged this pull request with Graphite.

@wschurman wschurman merged commit 7bd6df8 into main Nov 4, 2024
5 checks passed
@wschurman wschurman deleted the @wschurman/11-04-_updates_update_fingerprint_diff_algorithm branch November 4, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants