Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update lockfile to only include @types/node@20.11.0 #2412

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 7, 2024

Why

Running yarn typecheck in packages/eas-cli fails due to outdated @types/node being used.

This is caused because our lockfile resolves to the outdated node types.

  • Some libraries are using dependencies: @types/node: *, which is ok
  • Our lockfile resolves @types/node@* to 14.0.27, which is not ok

How

  • Update @types/node in our lockfile to only contain 20.11.0

Test Plan

Run this before changing anything:

  • $ node --print "require('@types/node/package.json').version"
  • Should print 14.0.27, which is not correct

After pulling this PR:

  • $ yarn install --frozen-lockfile
  • $ cd packages/eas-cli
  • $ yarn typecheck (should pass)
  • $ node --print "require('@types/node/package.json').version" (should print 20.11.0)

Copy link

github-actions bot commented Jun 7, 2024

Size Change: +646 kB (+1.26%)

Total Size: 51.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.9 MB +646 kB (+1.26%)

compressed-size-action

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (7f99694) to head (9f1e16d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2412   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         530      530           
  Lines       19509    19509           
  Branches     3968     3968           
=======================================
  Hits        10427    10427           
  Misses       8330     8330           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byCedric
Copy link
Member Author

byCedric commented Jun 7, 2024

/changelog-entry chore Update lockfile to only include @types/node@20.11.0

Copy link

github-actions bot commented Jun 7, 2024

✅ Thank you for adding the changelog entry!

@byCedric byCedric merged commit eefc133 into main Jun 7, 2024
9 checks passed
@byCedric byCedric deleted the @bycedric/fix/node-types branch June 7, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants