[eas-cli] update expo packages to SDK 52 versions

[szdziedzic]

Why

Update @expo packages to SDK 52 versions

How

Update @expo packages to SDK 52 versions

Fixes #2696

It seems like the privacy field was removed from the expo config in the SDK 52 update: https://expo.dev/changelog/2024/11-12-sdk-52.

I used AppPrivay.Unlisted for the createApp mutation input for which this is still required. It was an option selected for an app when exp.privacy was undefined.

It also seems that findWorkspaceRoot function in @expo/package-manager was changed to resolveWorkspaceRoot.

Test Plan

Tests, test commands manually

[szdziedzic]

• [eas-cli] update expo packages to SDK 52 versions #2706 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Subscribed to pull request

File Patterns	Mentions
**/*	@khamilowicz, @sjchmiela
packages/eas-cli/src/update/**	@EvanBacon, @byCedric, @wschurman

Generated by CodeMention

[wschurman]

What is the codepath where this is not using the versioned config getter for SDK 52? Might be worth focusing on making all versioned packages in eas-cli unused for SDK >= 52/53 like we did for getting the app config.

Upgrading these is always risky (we hit an issue last time we tried to upgrade them IIRC)

[github-actions]

Size Change: -264 kB (-0.5%)

Total Size: 52.6 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	52.6 MB	-264 kB (-0.5%)

_{compressed-size-action}

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.75%. Comparing base (48ebd9b) to head (0fb0e9c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tUtils/findProjectDirAndVerifyProjectSetupAsync.ts	0.00%	1 Missing ⚠️
packages/eas-cli/src/vcs/clients/git.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
+ Coverage   52.74%   52.75%   +0.01%     
==========================================
  Files         580      580              
  Lines       22283    22272      -11     
  Branches     4358     4353       -5     
==========================================
- Hits        11751    11747       -4     
+ Misses      10496    10489       -7     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[szdziedzic]

What is the codepath where this is not using the versioned config getter for SDK 52? Might be worth focusing on making all versioned packages in eas-cli unused for SDK >= 52/53 like we did for getting the app config. Upgrading these is always risky (we hit an issue last time we tried to upgrade them IIRC)

Discussed it in DMs with @wschurman and it seems like the best option for now is to go forward with this PR as-is for now then do the decoupling for the SDK 53 release. Decoupling seems like a right long-term call allowing us to avoid many of these upgrade-related issues in the future.

[szdziedzic]

It seems like this removed privacy thing is not a breaking change because ...This field was previously used when the Expo website had optional public-facing pages for projects, which we no longer provide.

Is it true @wschurman?

[wschurman]

Nice catch! This should fix it. https://app.graphite.dev/github/pr/expo/universe/17574/www-No-longer-require-obsolete-privacy-setting-in-app-creation-mutation

[wschurman]

Let's rebase on that www PR once approved and landed unless getting this out is urgent in which case leaving AppPrivay.Unlisted is fine for now (the field is a no-op anyways, doesn't do anything).

[wschurman]

yep, this modifyConfigAsync is probably a good thing to version next. We versioned syncUpdatesConfigurationAsync by creating a CLI for it in expo-updates.

[szdziedzic]

Thanks!

[github-actions]

✅ Thank you for adding the changelog entry!