Address comments

expo · Sep 7, 2021 · 7e7af00 · 7e7af00
1 parent 2b1852d
commit 7e7af00
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/packages/entity-database-adapter-knex/README.md b/packages/entity-database-adapter-knex/README.md
@@ -17,7 +17,7 @@ const knexInstance = knex({
     user: process.env['PGUSER'],
     password: process.env['PGPASSWORD'],
     host: process.env['PGHOST'],
-    port: parseInt(process.env['PGPORT']!, 10),
+    port: parseInt(nullthrows(process.env['PGPORT']), 10),
     database: process.env['PGDATABASE'],
   },
 });

diff --git a/.../entity-database-adapter-knex/src/__integration-tests__/PostgresEntityIntegration-test.ts b/.../entity-database-adapter-knex/src/__integration-tests__/PostgresEntityIntegration-test.ts
@@ -23,7 +23,7 @@ describe('postgres entity integration', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
     });

diff --git a/packages/entity-database-adapter-knex/src/__integration-tests__/PostgresInvalidSetup-test.ts b/packages/entity-database-adapter-knex/src/__integration-tests__/PostgresInvalidSetup-test.ts
@@ -16,7 +16,7 @@ describe('postgres entity integration', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
     });

diff --git a/packages/entity-database-adapter-knex/src/__integration-tests__/errors-test.ts b/packages/entity-database-adapter-knex/src/__integration-tests__/errors-test.ts
@@ -24,7 +24,7 @@ describe('postgres errors', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
     });
@@ -52,7 +52,7 @@ describe('postgres errors', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
       acquireConnectionTimeout: 1,

diff --git a/.../entity-full-integration-tests/src/__integration-tests__/EntityCacheInconsistency-test.ts b/.../entity-full-integration-tests/src/__integration-tests__/EntityCacheInconsistency-test.ts
@@ -111,7 +111,7 @@ describe('Entity cache inconsistency', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
     });

diff --git a/...es/entity-full-integration-tests/src/__integration-tests__/EntityEdgesIntegration-test.ts b/...es/entity-full-integration-tests/src/__integration-tests__/EntityEdgesIntegration-test.ts
@@ -44,7 +44,7 @@ describe('EntityMutator.processEntityDeletionForInboundEdgesAsync', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
     });

diff --git a/...integration-tests/src/__integration-tests__/EntitySelfReferentialEdgesIntegration-test.ts b/...integration-tests/src/__integration-tests__/EntitySelfReferentialEdgesIntegration-test.ts
@@ -173,7 +173,7 @@ describe('EntityMutator.processEntityDeletionForInboundEdgesAsync', () => {
         user: nullthrows(process.env['PGUSER']),
         password: nullthrows(process.env['PGPASSWORD']),
         host: 'localhost',
-        port: parseInt(process.env['PGPORT']!, 10),
+        port: parseInt(nullthrows(process.env['PGPORT']), 10),
         database: nullthrows(process.env['PGDATABASE']),
       },
     });