fix: constrain entity fields type to string-keyed object

[wschurman]

Why

This allows us to remove the any typecast in EntityConfiguration.ts and is more correct: only string-keyed field objects are allowed.

This is in preparation for addressing this comment: #233 (comment)

How

Add type constraint where necessary.

Test Plan

yarn tsc

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7c3c985) to head (4caea03).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         1895      1895           
  Branches       261       261           
=========================================
  Hits          1895      1895           

Flag	Coverage Δ
integration	100.00% <100.00%> (ø)
unittest	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Josh-McFarlin]

Is the plan to replace T extends Record<string, any> with a type omitting prototype names?

[wschurman]

Is the plan to replace T extends Record<string, any> with a type omitting prototype names?

Nope, I just noticed the any cast at the callsite where I was planning to add validation and decided that it'd be easy enough to get rid of the any cast (which is a code smell).

That being said, your idea is interesting and I wonder if it's possible. I think the typescript Record type extends Object which has those properties.

[Josh-McFarlin]

lgtm

[wschurman]

It seems like omitting Object core types is not supported: https://www.typescriptlang.org/play/?#code/GYVwdgxgLglg9mABAIwDwBUBiMCmAbAEwGdEcAPKHMYxAeQFsYpUAlHCOAJwNSKk5hgA5gBpEAQzABPAHxiA5FDgBlfoKHyZMgBTBchIgC5EWfcQCUxgG5wYBRAG8AUIleI9+YgDolqgcO1zAG4nAF8gA