fix: disallow keys of JS Object prototype for safety #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses this comment: #233 (comment)
Essentially, we want to disallow naming entity fields the same as some predefined JS prototype fields so that code in entity that uses
for .. in
loops over the fields object aren't accidentally unsafe (it's too easy a mistake to make).How
Disallow fields, add test.
Test Plan
Run test.