feat: better typing on filterMap for use with predicates #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When a map is filtered with a predicate, if the predicate signals a type using the
is
operator, then the resulting map should be have values of the type of the predicate result. For instance, if the typeMap<string, string | null>
is filtered with atruthy
predicate, then the return type offilterMap
should beMap<string, string>
.Array accomplishes this with a function declaration overload: https://github.com/microsoft/TypeScript/blob/master/lib/lib.es5.d.ts#L1176
How
Add a function declaration overload.
Test Plan
yarn tsc
, also run new test.