Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move responsibility of transformer to generic redis cacher #153

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 4, 2022

Why

Move the cache object <=> entity object transformation to be the Generic Redis Cache Adapter's responsibility. Followup from #152 (review)

Test Plan

  • new tests pass

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #153 (807edfd) into master (a2c6dd7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   95.94%   95.92%   -0.02%     
==========================================
  Files          74       74              
  Lines        1874     1866       -8     
  Branches      204      204              
==========================================
- Hits         1798     1790       -8     
  Misses         75       75              
  Partials        1        1              
Flag Coverage Δ
integration 95.92% <100.00%> (-0.02%) ⬇️
unittest 95.92% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/entity/src/EntityCacheAdapter.ts 100.00% <ø> (ø)
...tity-cache-adapter-redis/src/GenericRedisCacher.ts 100.00% <100.00%> (ø)
...ntity-cache-adapter-redis/src/RedisCacheAdapter.ts 100.00% <100.00%> (ø)
...ndary-cache-redis/src/RedisSecondaryEntityCache.ts 100.00% <100.00%> (ø)
...ages/entity/src/internal/ReadThroughEntityCache.ts 95.23% <100.00%> (-0.22%) ⬇️
...kages/entity/src/utils/testing/StubCacheAdapter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c6dd7...807edfd. Read the comment docs.

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@quinlanj quinlanj merged commit 03a1fce into master Feb 7, 2022
@quinlanj quinlanj deleted the @quin/cacheAdapterTransformer2 branch February 7, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants