Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript to 3.9 #18

Merged
merged 2 commits into from
May 13, 2020
Merged

Upgrade typescript to 3.9 #18

merged 2 commits into from
May 13, 2020

Conversation

wschurman
Copy link
Member

Why

Release notes: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-9.html#breaking-changes

For this project, the changes that affect us are:

  • speed improvements
  • Type Parameters That Extend any No Longer Act as any

How

Upgrade in package.json

Test Plan

yarn test
yarn integration
yarn typedoc (depends on typescript)

@wschurman wschurman requested a review from jkhales May 13, 2020 18:03
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          63       63           
  Lines        1138     1138           
  Branches       97       97           
=======================================
  Hits         1007     1007           
  Misses         62       62           
  Partials       69       69           
Flag Coverage Δ
#integration 88.48% <ø> (ø)
#unittest 88.48% <ø> (ø)
Impacted Files Coverage Δ
...-adapter-knex/src/PostgresEntityDatabaseAdapter.ts 78.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cf679...e9a3ddc. Read the comment docs.

Copy link

@jkhales jkhales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@wschurman wschurman merged commit 9129d74 into master May 13, 2020
@wschurman wschurman deleted the @wschurman/upgrade-ts branch May 13, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants