chore: add test coverage for remaining code #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## @wschurman/can-delete-5 #231 +/- ##
============================================================
+ Coverage 99.68% 100.00% +0.31%
============================================================
Files 69 69
Lines 1887 1884 -3
Branches 263 261 -2
============================================================
+ Hits 1881 1884 +3
+ Misses 6 0 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wschurman
force-pushed
the
@wschurman/can-delete-5
branch
from
80e018a
to
e275811
Compare
wschurman
force-pushed
the
@wschurman/can-delete-6
branch
from
be16309
to
4273fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR brings the test coverage of entity to 100%.
How
Add a few more test cases for things missing test cases (but still need them).
Test Plan
Run tests, check coverage.