fix: edge deletion behavior cyclic import structure again #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Apparently #89 wasn't sufficient for all cases. With the way entities are encouraged to be written, it seems that even with one side of this cycle being defined as a function isn't sufficient to squash all import cycles. I think this is a fairly unique case though as it is literally defining a cycle so I still don't think that having the whole companion or configuration be a function is necessary (don't foresee any other future features needing to specify other entities in configurations).
How
Make the other direction edge specification a function as well.
Test Plan
This one is harder to repro using a simple test case. To test this, I
yarn link
'ed theentity
package into Expo code where we're seeing the behavior and ensured it fixed it.