Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[moti] Upgrade to Expo SDK 43 and Moti 0.16 #308

Closed
wants to merge 2 commits into from

Conversation

byCedric
Copy link
Member

Web seems a little bit off, but not sure why. Instead of shrinking + fading away, it grows first (cc @nandorojo). Native does work great.

@nandorojo
Copy link
Contributor

Can you try this patch from reanimated 2.3 beta?

software-mansion/react-native-reanimated#2280

@byCedric
Copy link
Member Author

byCedric commented Oct 24, 2021

Ah ok, if it's a known issue from rn reanimated, let's skip it. When it's published as stable, it should be fixed right?

@nandorojo
Copy link
Contributor

Yeah, they also said they’d pull this change into 2.2 since it’s JS-only.

Another (likely) fix in the meantime is if you set transition={{ type: ‘timing’ }}.

@nandorojo
Copy link
Contributor

@EvanBacon
Copy link
Contributor

Is this ready to merge?

@nandorojo
Copy link
Contributor

We need to upgrade reanimated to 2.2.4 for fixed web support, and then yes.

@nandorojo
Copy link
Contributor

Although it has ~2.2.0 already, and no lock file, so I assume that would resolve to 2.2.4(?)

@byCedric
Copy link
Member Author

byCedric commented Nov 5, 2021

react-native-reanimated only published 2.2.4 under a "stable" tag, not the "latest" flag. So we will still pull in 2.2.3 unfortunately. But as you mentioned, there is no lockfile so once they switch the tag it's in here as well

@blixit
Copy link
Contributor

blixit commented Nov 21, 2021

Expo has moved it version of react-native from 0.64.2 to 0.64.3: expo/expo#15108

I think you can update your PR accordingly.

@IlyaTaidi
Copy link

The Moti example isn't serving properly to web, native works great but web is throwing reanimated errors
image

@byCedric
Copy link
Member Author

@IlyaTaidi Please don't comment on older unrelated PRs. This PR is no longer relevant because it updates the SDK to 43, while we are already at SDK 44.

That being said, it's an issue with react-native-reanimated@2.3.2, see software-mansion/react-native-reanimated#3026. You can upgrade to 2.4.1 to avoid it, or wait until a fix is released.

@byCedric byCedric closed this Feb 21, 2022
@byCedric byCedric deleted the @bycedric/upgrade-moti branch February 21, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants