Merge branch 'master' into @evanbacon/expo-cli/esbuild

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -2,47 +2,52 @@ name: "\U0001F41B Bug Report in Expo CLI"
 about: 'You want to report a reproducible bug or regression in Expo CLI or related tooling.'
 labels: 'bug'
 issue_body: true
-inputs:
-  - type: description
+body:
+  - type: markdown
     attributes:
       value: "We're looking to keep questions on our forums and bug reports on the GitHub repo. For questions and help using Expo CLI, post in our [community forums](https://forums.expo.io/c/expo-cli) (log in with your Expo developer account)."
-  - type: description
+  - type: markdown
     attributes:
       value: Found a bug in the Expo SDK? Open a bug report [here](https://github.com/expo/expo/issues/new?assignees=&labels=needs+review&template=bug_report.yml) instead.
-  - type: description
+  - type: markdown
     attributes:
       value: Thanks for taking the time to file a bug report! Please fill out this form as completely as possible.
-  - type: description
+  - type: markdown
     attributes:
       value: If you leave out sections there is a high likelihood your issue will be closed. If you have a question, not a bug report, please post it on our [forums](https://forums.expo.io/) instead.
   - type: textarea
+    validations:
+      required: true
     attributes:
       label: Summary
-      required: true
       description: Describe the issue in 1 or 2 sentences
       placeholder: Clearly describe what the expected behavior is vs. what is actually happening. This should be as short as possible, while still communicating all the necessary information. If your summary is just 'X library/method isn't working', then you need to continue debugging yourself and provide more information.
   - type: textarea
+    validations:
+      required: true
     attributes:
       label: Environment
-      required: true
       placeholder: Run `expo diagnostics` and paste the output here
   - type: input
+    validations:
+      required: true
     attributes:
       label: 'Please specify your device/emulator/simulator platform, model and version'
-      required: true
   - type: textarea
+    validations:
+      required: false
     attributes:
       label: Error output
-      required: false
       placeholder: If you're running into an error message, please run the same command with `EXPO_DEBUG=true <your command here>` and paste output here.
   - type: textarea
+    validations:
+      required: true
     attributes:
       label: Reproducible demo or steps to reproduce from a blank project
-      required: true
       description: 'This should include as little code as possible, do not simply link your entire project. Sharing a link to a [Snack](https://snack.expo.io/) is a GREAT way to provide a reproducible demo :) If a reproducible demo, or a complete list of steps from blank project to bug, are not provided, it is very likely your issue will be closed. Read [here more guidance](https://stackoverflow.com/help/mcve).'
-  - type: description
+  - type: markdown
     attributes:
       value: Please make sure contributors can follow the steps your provided in order to reproduce the bug.
-  - type: description
+  - type: markdown
     attributes:
       value: "**Realize that it is up to you to debug your code and be as certain as possible that the bug is with Expo, not with your own app.** [Here's an excellent guide to debugging you can follow](https://github.com/expo/fyi/blob/master/manual-debugging.md#how-to-narrow-down-the-source-of-an-error-a-step-by-step-guide-to-good-old-fashioned-manual-debugging)."

.github/ISSUE_TEMPLATE/enhancement.yml

@@ -2,13 +2,14 @@ name: "\U0001F64B Enhancement"
 about: 'Want us to add something to Expo CLI?'
 labels: 'enhancement'
 issue_body: false
-inputs:
-  - type: description
+body:
+  - type: markdown
     attributes:
       value: Thanks for helping us make Expo even better! 😀 Unfortunately, this is not the right place for feature requests. Please find and upvote your feature (or create a new one) at https://expo.canny.io instead.
   - type: dropdown
+    validations:
+      required: true
     attributes:
       label: Do you understand that any feature requests opened in the core Expo repository will be closed?
-      required: true
-      choices:
-        - Yes
+      options:
+        - 'Yes'

.github/workflows/test.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: ['10', '12']
+        node: ['12', '14']
     name: Build with Node ${{ matrix.node }}
     steps:
       - uses: actions/checkout@v2
@@ -33,10 +33,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ['10', '12']
+        node: ['12', '14']
         package:
           [
-            electron-adapter,
             dev-tools,
             babel-preset-cli,
             config,
@@ -48,6 +47,7 @@ jobs:
             json-file,
             metro-config,
             package-manager,
+            prebuild-config,
             pkcs12,
             plist,
             pwa,
@@ -71,6 +71,7 @@ jobs:
         # run: cd packages/${{ matrix.package }} && yarn test --coverage
         env:
           CI: true
+          EXPO_DEBUG: true
       # - name: Get Test Flag Name
       #   id: cov-flag-name
       #   run: echo "::set-output name=flag::$(echo ${{ matrix.package }} | perl -pe 's/[^a-z]+([a-z])/\U\1/gi;s/^([A-Z])/\l\1/')"

.github/workflows/test_windows.yml

@@ -0,0 +1,73 @@
+name: Test Packages Windows
+on:
+  push:
+    branches: [master]
+  pull_request:
+    types: [opened, synchronize]
+
+jobs:
+  build:
+    runs-on: windows-latest
+    strategy:
+      matrix:
+        node: ['12', '14']
+    name: Build with Node ${{ matrix.node }}
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 1
+      - name: Setup node
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node }}
+      - run: yarn install --frozen-lockfile --check-files
+      - run: yarn lerna run prepare --stream
+      - run: yarn lint --max-warnings=0
+      - uses: actions/cache@v2
+        with:
+          path: '*'
+          key: v2-${{ github.sha }}-${{ matrix.node }}
+  test:
+    runs-on: ubuntu-latest
+    needs: build
+    strategy:
+      fail-fast: false
+      matrix:
+        node: ['12', '14']
+        package:
+          [
+            dev-tools,
+            babel-preset-cli,
+            config,
+            config-plugins,
+            dev-server,
+            expo-cli,
+            expo-codemod,
+            image-utils,
+            json-file,
+            metro-config,
+            package-manager,
+            pkcs12,
+            plist,
+            pwa,
+            schemer,
+            uri-scheme,
+            webpack-config,
+            xdl,
+          ]
+    name: Test ${{ matrix.package }} on Node ${{ matrix.node }}
+    steps:
+      - uses: actions/cache@v2
+        with:
+          path: '*'
+          key: v2-${{ github.sha }}-${{ matrix.node }}
+      - name: Set up Node
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node }}
+      - name: Test ${{ matrix.package }}
+        run: cd packages/${{ matrix.package }} && yarn test
+        # run: cd packages/${{ matrix.package }} && yarn test --coverage
+        env:
+          CI: true
+          EXPO_DEBUG: true

.prettierignore

@@ -5,7 +5,6 @@
 /packages/dev-tools/.next
 /packages/dev-tools/build
 /packages/dev-tools/fragmentTypes.json
-/packages/electron-adapter/build
 /packages/expo-cli/build
 /packages/expo-codemod/build
 /packages/expo-optimize/build

.prettierrc

@@ -4,5 +4,6 @@
   "singleQuote": true,
   "jsxBracketSameLine": true,
   "trailingComma": "es5",
-  "arrowParens": "avoid"
+  "arrowParens": "avoid",
+  "endOfLine": "auto"
 }