Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

fix(config): add missing globby dependency #1931

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Apr 19, 2020

I'm updating the Standard Version Expo library and came across this. globby is used in Config.ts, I think it should be added here 😄 It works with this version, but do correct this if it needs an older one!

@codecov-io
Copy link

Codecov Report

Merging #1931 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1931   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files          84       84           
  Lines        2598     2598           
  Branches      719      728    +9     
=======================================
  Hits         1579     1579           
+ Misses        996      989    -7     
- Partials       23       30    +7     
Impacted Files Coverage Δ
packages/pwa/src/Manifest.ts 37.25% <0.00%> (ø)
packages/config/src/Config.ts 65.45% <0.00%> (ø)
packages/config/src/android/Manifest.ts 23.40% <0.00%> (ø)
...ackages/webpack-config/src/addons/withDevServer.ts 33.33% <0.00%> (ø)
...es/webpack-config/src/loaders/createBabelLoader.ts 46.66% <0.00%> (ø)
...webpack-config/src/plugins/FaviconWebpackPlugin.ts 4.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22017ca...c9a58cf. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants