Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[expo cli] mostly remove inquirer #2892

Merged
merged 22 commits into from
Nov 17, 2020
Merged

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Nov 16, 2020

Why

How

  • copy the changes made in eas-cli.
  • changed types
    • list -> select
    • input or undefined -> text
  • changed options
    • pageSize -> optionsPerPage (also added the missing type in our abstraction).
    • default -> initial
    • filter -> format
    • choices.name -> choices.title

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks!

@EvanBacon EvanBacon marked this pull request as ready for review November 17, 2020 14:45
@EvanBacon EvanBacon merged commit d5a20f0 into master Nov 17, 2020
@EvanBacon EvanBacon deleted the @evanbacon/expo-cli/remove-inquirer branch November 17, 2020 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants