This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR is part of a series of changes that will shift SWs to require local setup.
We don't enable service workers by default (anymore) so it's a bit unfortunate that every project needs to install the code required for adding them (which accounts for a large portion of
expo cli
). Workbox is also a bit slow to upgrade webpack versions, and that transitively effects our ability to upgrade. Our offline feature only supports SPA styled websites (Expo web default), which means Next.js and Gatsby users end up having to install a bunch of code that they won't be using either.Workbox uses a lot of deprecated dependencies, which ends up adding lots of warnings to expo-cli installation. Removing workbox will drop the following install warnings when users run
npm i -g expo-cli
:With
yarn add expo-cli
:This is 28% decrease in warnings.