[modules][Android] Fixed views are not correctly initialized after reloading on Android #20063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading on Android
tsapeta
approved these changes
Nov 15, 2022
Kudo
added a commit
that referenced
this pull request
Nov 16, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
lukmccall
deleted the
@lukmccall/core/fix-modules-not-working-after-reload
branch
expo-bot
added
bot: passed checks
2 tasks
Kudo
added a commit
that referenced
this pull request
Nov 17, 2022
Kudo
added a commit
that referenced
this pull request
Nov 22, 2022
Kudo
pushed a commit
that referenced
this pull request
Nov 24, 2022
…loading on Android (#20063) Closes #20033. We can't invalidate `mWrapperDelegateHolders` because view managers won't receive the correct app context. This variable memorizes and updates app context references in the view managers exported from Kotlin. That regression has been introduced in #19538. However, I don't think not clearing `mWrapperDelegateHolders` will affect the `Updates.reloadAsync` behavior. - bare-expo and NCL ✅ (cherry picked from commit bd9b2b2)
This was referenced Nov 27, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #20033.
How
We can't invalidate
mWrapperDelegateHoldersbecause view managers won't receive the correct app context. This variable memorizes and updates app context references in the view managers exported from Kotlin.That regression has been introduced in #19538. However, I don't think not clearing
mWrapperDelegateHolderswill affect theUpdates.reloadAsyncbehavior.Test Plan