[av][ncl][go] fix audio and video qa issues #21055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Changelog entry in wrong CHANGELOG file
Generated by ExpoBot 🤖 against 1697397 |
expo-bot
added
bot: needs changes
Kudo
requested review from
ide,
tsapeta,
brentvatne and
barthap
as code owners
Kudo
requested review from
lukmccall
and removed request for
brentvatne,
barthap,
ide and
tsapeta
lukmccall
approved these changes
Feb 2, 2023
jakobo
added a commit
to jakobo/expo
that referenced
this pull request
Feb 2, 2023
…flipper * upstream/main: (47 commits) [docs] Update Hermes guide to state that Hermes is the new default engine (expo#21047) chore: don't mark issues with the "Issue accepted" label as stale (expo#21058) Switch default JS engine to Hermes (expo#21001) [mail-composer][android] fix composeAsync not resolving after send/ discard (expo#20869) Update CHANGELOG.md (expo#21061) [core][iOS] Fix expo modules aren't added to global (expo#21037) [test-suite] Fix import in the Image example (expo#21043) [test-suite] fix video hanging (expo#21057) [av][ncl][go] fix audio and video qa issues (expo#21055) [tools] Selecting pull requests to label in the publish command (expo#20991) [document-picker] fill missing descriptions in `DocumentResult` type (expo#21040) [tools] Bump http-cache-semantics from 4.1.0 to 4.1.1 (expo#21049) Bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs (expo#21050) [apps][yarn-workspace] replace deprecated activateKeepAwake update changelogs for react-native 0.71 upgrade (expo#20858) Upgrade react native to 0.71.2 (expo#21045) [go] update @shopify/react-native-skia to 0.1.172 (expo#21014) [stripe] Upgrade stripe to 0.23.1 (expo#20964) [expo-firebase-*] Remove libraries (expo#20979) [docs] Update expo-secure-store to add info about Export compliance (expo#21021) ...
barthap
reviewed
Feb 3, 2023
Comment on lines
+226
to
+232
| private void emitSampleBufferEvent(final byte[] bytes, final double currentPositionSeconds) { | ||
| final UIManager uiManager = mUiManager.get(); | ||
| if (uiManager != null) { | ||
| uiManager.runOnClientCodeQueueThread(() -> { | ||
| sampleBufferCallback(bytes, currentPositionSeconds); | ||
| }); | ||
| } |
There was a problem hiding this comment.
The currentPositionSeconds passed into an async call will no longer be accurate, hopefully this isn't a significant loss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix audio and video issues from sdk48 android unversioned qa
How
onSlidingCompleteissue. this pr update the vendored slider to the latest version with a fix.setVolumeAsyncunhandled promise rejection: accesssoundwhen it's before starting (undefined).Test Plan
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).