Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][Android] Add functions converter #21976

Merged
merged 3 commits into from
Apr 6, 2023
Merged

[core][Android] Add functions converter #21976

merged 3 commits into from
Apr 6, 2023

Conversation

lukmccall
Copy link
Contributor

Why

Adds functions converter.

How

  • Adds a frontend and backend converter for js function type
  • Adds ability to call those functions via Kotlin code

Test Plan

  • unit tests ✅

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 4, 2023
lukmccall and others added 2 commits April 6, 2023 16:06
@lukmccall
[skip ci] Fix CI
f3de6d7
@lukmccall @expo-bot
[skip ci]Update packages/expo-modules-core/CHANGELOG.md
39e9457 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit 879827b into main Apr 6, 2023
@lukmccall lukmccall deleted the @lukmccall/core/add-functions-converters branch April 6, 2023 14:07
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@Kudo Kudo Kudo approved these changes

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukmccall @Kudo @tsapeta @expo-bot