[android][brightness] Migrate to Expo Modules API #22037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
lukmccall
requested changes
Apr 12, 2023
packages/expo-brightness/android/src/main/java/expo/modules/brightness/BrightnessModule.kt
Outdated
Show resolved
Hide resolved
packages/expo-brightness/android/src/main/java/expo/modules/brightness/BrightnessModule.kt
Outdated
Show resolved
Hide resolved
packages/expo-brightness/android/src/main/java/expo/modules/brightness/BrightnessModule.kt
Outdated
Show resolved
Hide resolved
packages/expo-brightness/android/src/main/java/expo/modules/brightness/BrightnessModule.kt
Outdated
Show resolved
Hide resolved
lukmccall
approved these changes
Apr 13, 2023
tsapeta
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Continue migration to Expo Modules API.
How
Followed the typical migration steps.
Test Plan
Tested in bare expo. All the system brightness methods currently don't work as they require permission only available to system apps. I suggest deprecating all the system methods. This would mean the permission request could be removed and the API would match what's available on iOS.