[notifications] Remove deprecated experienceId from getExpoPushTokenAsync options #22303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-7254 Remove deprecated `Notifications.getExpoPushTokenAsync()` experienceId field
We should remove the `experienceId` parameter from Notifications getExpoPushTokenAsync function as it was deprecated on SDK 48 Check the link below for reference |
tsapeta
approved these changes
Apr 27, 2023
expo-bot
added
bot: passed checks
wschurman
approved these changes
Apr 27, 2023
3 tasks
gabrieldonadel
deleted the
@gabrieldonadel/remove-deprecated-experience-id
branch
gabrieldonadel
added a commit
that referenced
this pull request
Apr 28, 2023
…oPushTokenAsync options for SDK 49 (#22305) <!-- disable:changelog-checks --> # Why Follow-up PR for #22303 Closes ENG-7254 # How `et generate-docs-api-data --packageName expo-notifications` # Test Plan Changes have been tested by running docs locally.  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
douglowder
pushed a commit
that referenced
this pull request
May 2, 2023
…sync options (#22303) # Why This option was deprecated on SDK 48 and should now be completely removed on SDK 49. From now on users must specify a `projectId` either through `ExpoTokenOptions` or via the app manifest Closes ENG-7254 Follow up PR updating docs -> #22305 # How This PR removes the deprecated `experienceId` field from the `getExpoPushTokenAsync` function options. # Test Plan Run NCL # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
douglowder
pushed a commit
that referenced
this pull request
May 2, 2023
…oPushTokenAsync options for SDK 49 (#22305) <!-- disable:changelog-checks --> # Why Follow-up PR for #22303 Closes ENG-7254 # How `et generate-docs-api-data --packageName expo-notifications` # Test Plan Changes have been tested by running docs locally.  # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This option was deprecated on SDK 48 and should now be completely removed on SDK 49. From now on users must specify a
projectIdeither throughExpoTokenOptionsor via the app manifestCloses ENG-7254
Follow up PR updating docs -> #22305
How
This PR removes the deprecated
experienceIdfield from thegetExpoPushTokenAsyncfunction options.Test Plan
Run NCL
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).