[ios][image-picker] Add preferredAssetRepresentationMode to image picker #22456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
lukmccall
requested changes
May 17, 2023
| @@ -142,6 +142,7 @@ public class ImagePickerModule: Module, OnMediaPickingResultHandler { | |||
| // selection limit = 1 --> single selection, reflects the old picker behavior | |||
| configuration.selectionLimit = options.allowsMultipleSelection ? options.selectionLimit : SINGLE_SELECTION | |||
| configuration.filter = options.mediaTypes.toPickerFilter() | |||
| configuration.preferredAssetRepresentationMode = options.preferredAssetRepresentationMode.toAssetRepresentationMode() | |||
There was a problem hiding this comment.
Suggested change
| configuration.preferredAssetRepresentationMode = options.preferredAssetRepresentationMode.toAssetRepresentationMode() | |
| if #available(iOS 14, *) { | |
| configuration.preferredAssetRepresentationMode = options.preferredAssetRepresentationMode.toAssetRepresentationMode() | |
| } |
There was a problem hiding this comment.
@lukmccall Thank you, I've added it!
lukmccall
approved these changes
May 19, 2023
3 tasks
lukmccall
pushed a commit
that referenced
this pull request
May 22, 2023
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> In my previous PR #22456, I added the changelog entry under the wrong version, it should be under `Unpublished` instead of `14.2.0`, my bad. # How <!-- How did you build this feature or fix this bug and why? --> - Move the entry to `Unpublished` # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
preferredAssetRepresentationModegives us the option to skip transcodingHow
ImagePickerOptionsTest Plan
bare-expoapp on iOSexpo-image-pickerand launched the photo library picker with all the options.hevcvideo withautomaticandcurrent,currentis much fasterChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).